Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint span goes missing when errors occur #11

Open
garthk opened this issue May 17, 2019 · 2 comments
Open

Blueprint span goes missing when errors occur #11

garthk opened this issue May 17, 2019 · 2 comments
Assignees

Comments

@garthk
Copy link
Collaborator

garthk commented May 17, 2019

I'm getting my root span from Opencensus.Plug.Trace and Opencensus.Absinthe.Middleware, but not the span from Opencensus.Absinthe.Phase.Pop.

@garthk
Copy link
Collaborator Author

garthk commented Jun 23, 2019

Dug into it as part of #17. Absinthe just crashes straight out. I reckon I'll need special handling in Opencensus.Absinthe.Plug to:

  • Hook execution after the plugs finish e.g. Plug.Exception, Opencensus.Plug.Trace
  • Spot ocp thinking it's deeper-nested than plausible
  • Whileocp thinks we're in the right trace but not the right span:
    • If it's one of our spans, add attributes indicating a crash-out
    • ocp.finish_span/0

@garthk garthk self-assigned this Jun 23, 2019
@garthk
Copy link
Collaborator Author

garthk commented Jun 23, 2019

Defining my own call/2 and wrapping the call to super/2 will give me a crack at it.

garthk pushed a commit that referenced this issue Jun 24, 2019
garthk pushed a commit that referenced this issue Jun 25, 2019
garthk pushed a commit that referenced this issue Jul 12, 2019
WIP: promising lead on #11

Still having trouble with unwinding errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant