Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using OBS distribution IDs #1169

Open
hennevogel opened this issue Mar 29, 2022 · 2 comments
Open

Stop using OBS distribution IDs #1169

hennevogel opened this issue Mar 29, 2022 · 2 comments
Labels
Refactoring 🔧

Comments

@hennevogel
Copy link
Member

As you can see in #1167 there is some code that depends on OBS distribution IDs. Those IDs change all the time, we should not rely on them being hardcoded.
@hellcp
Copy link
Member

hellcp commented Mar 29, 2022

There should have been tests to catch that not being a valid id anymore too

@hennevogel
Copy link
Member Author

for the workaround we currently have, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactoring 🔧
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hennevogel @hellcp