Crash on Add New Source File in IDE in Windows for Workgroups 3.11

[nickkeane]

The IDE crashes when I create a new source file in my installation of Open Watcom in 86Box. When I create a project, set target environment to Win16 and image type as Executable, it creates the project. Then, when clicking Sources -> New Source and entering "main.c" and clicking Add or pressing the Enter key, the IDE crashes.

https://pasteboard.co/hog7EMkxgSPB.png

[jmalak]

Thank you for your bug report.

[Baron-von-Riedesel]

I confirm this crash - actually, it's a GPF in the IDE, file vfilelst.cpp, function AddSrcDlgProc(). Register DS contains a selector of Win16 dll COMMDLG, which almost certainly is wrong - since it is a so-called callback, register DS "should" be set on function entry, which obviously isn't done.

Comparing ide.exe with OW v1.9, OW20's ide has just 11 exports, while OW19's has 15 - and the export for AddSrcDlgProc() is one of those that are missing.

[jmalak]

@Baron-von-Riedesel thanks for your analysis. It is missing export modifier on callback function for 16-bit widows.
The main difference between OW 1.9 and OW 2.0 sources for 16-bit Windows that callback functions in OW 2.0 must be explicitly exported against OW 1.9 where is implicitly exported. Most of callback functions were fixed, but some is still incorrect (no exported).
I will check and add missing export modifier for appropriate callback 16-bit Windows function.