Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit shutdown_signal_provider methods at API level #1679

Closed
lalitb opened this issue Apr 23, 2024 · 3 comments · Fixed by #1742 or #1743
Closed

Revisit shutdown_signal_provider methods at API level #1679

lalitb opened this issue Apr 23, 2024 · 3 comments · Fixed by #1742 or #1743

Comments

@lalitb
Copy link
Member

lalitb commented Apr 23, 2024

          I think we need to revisit `shutdown_*_provider` methods as they are at the API level. The instrumented libraries shouldn't have the method to shutdown the LoggerProvider enabled by the application.

Originally posted by @lalitb in #1643 (comment)

@TommyCpp TommyCpp added this to the Release Blcokers for 0.23 milestone Apr 24, 2024
@cijothomas
Copy link
Member

#1643 (comment) We may be able to this entirely at API level, for the logging signal. (still need it/similar capability for metrics,traces)

@TommyCpp
Copy link
Contributor

We may be able to this entirely at API level

To clearify you mean remove shutdown, get logger, get logger provider, set logger provider entirely for logging signal?

@cijothomas cijothomas mentioned this issue May 11, 2024
3 tasks
@cijothomas
Copy link
Member

For v0.23 release:
This is not an issue for logs, as logs removed the global shutdown completely.
Not an issue for traces, as global shutdown existed even before this release.
For metrics, this is newly introduced in v0.23. An example on how to shutdown even without the global_shutdown : #1739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants