Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics Number data points requirements for value #286

Open
bogdandrutu opened this issue Mar 26, 2021 · 2 comments
Open

Metrics Number data points requirements for value #286

bogdandrutu opened this issue Mar 26, 2021 · 2 comments
Assignees
@jmacd
Labels
area:data-model release:allowed-for-ga Editorial changes that can still be added to the GA spec since they don't require action by SIGs spec:metrics
Projects
Spec - Metrics Data Model and Protocol

Comments

@bogdandrutu
Copy link
Member

Define if it is an error or not to receive for the same "Resource, InstrumentationLibrary, MetricName, Labels/Attributes, StartTime" first point with int value and next point with double value.

We need to document this behavior.
@RichiH
Copy link
Member

RichiH commented Mar 29, 2021

Copying from Slack to make sure it's not lost: OM considers it non-breaking, but not something that should happen frequently: https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#exposition-across-time-and-metric-evolution

@jsuereth jsuereth added this to Types, Schema and Metadata in Spec - Metrics Data Model and Protocol Mar 30, 2021
@jsuereth jsuereth added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Mar 30, 2021
@jsuereth
Copy link
Contributor

We discussed this in the Metrics Data Model SiG.

  1. Based on previous discussion we don't think this is blocking declaring our API sstable.
  2. We should specify what is allowable within a collector ("on the wire"), specifically around aggregations.

We had talked about a notion of "weak conformance" that allows migrating int to double when this situation occurs. Specification remains TBD.

@jsuereth jsuereth added release:allowed-for-ga Editorial changes that can still be added to the GA spec since they don't require action by SIGs and removed release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmacd jmacd

Labels
area:data-model release:allowed-for-ga Editorial changes that can still be added to the GA spec since they don't require action by SIGs spec:metrics
Projects
No open projects
Spec - Metrics Data Model and Protocol
Types, Schema and Metadata
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jsuereth @RichiH @bogdandrutu @jmacd