Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SDK configuration into own package #1245

Closed
brettmc opened this issue Feb 29, 2024 · 1 comment
Closed

Move SDK configuration into own package #1245

brettmc opened this issue Feb 29, 2024 · 1 comment
Milestone

Comments

@brettmc
Copy link
Collaborator

brettmc commented Feb 29, 2024

Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue in opentelemetry-specification first.

Is your feature request related to a problem?
Per otel spec, most components should only depend on the API, and not the SDK. Because all of our configuration-management code is in the SDK, it's not usable by contrib modules etc which need to deal with config. So, we end up with duplicate code and inconsistent handling of config.

Describe the solution you'd like
If we break config related code (OpenTelemetry\SDK\Common\Configuration\*) into its own small package that other packages can use, then they can use config without requiring the SDK.

Describe alternatives you've considered
I once thought about creating a configuration-resolver interface, and writing a minimal config resolver in the API (matching the interface of the SDK version). The implementation was very similar to the SDK one. But, now that we also have config management in the Context package, that would create a circular dependency between API and Context.

@brettmc brettmc added this to the 1.1 milestone Mar 4, 2024
@brettmc
Copy link
Collaborator Author

brettmc commented May 8, 2024

Closing, replaced by #1304 which is an improved (and draft spec-compliant) way to configure all of the things.

@brettmc brettmc closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant