Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baggage span processor - key predicate #1295

Open
MikeGoldsmith opened this issue Apr 29, 2024 · 0 comments
Open

Baggage span processor - key predicate #1295

MikeGoldsmith opened this issue Apr 29, 2024 · 0 comments

Comments

@MikeGoldsmith
Copy link
Member

MikeGoldsmith commented Apr 29, 2024

This issue is to track adding a method of selecting what baggage key entries should be copied.

Feedback in the JS contrib PR was to allow a user-provided predicate function. This puts the responsibility on the user to ensure sensitive baggage keys are not copied while also not prescribing how that is determined.

  • Baggage span processor - key predicate opentelemetry-js-contrib#2166

            > What about making the baggage items that are added as spans tags configurable, with the option to provide `*` for all - like here: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/355003538a4dcf7ec58b6d9be42086c53238bdac/instrumentation/log4j/log4j-appender-2.17/library/README.md?plain=1#L101
    

We had a similar discussion in the .NET contrib project but thought it was more complicated than just using a set of prefixes so created an issue to continue the discussion. The plain processor that copies all baggage entries (like using * in your example) is likely to be accepted first.

Originally posted by @MikeGoldsmith in #1290 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant