Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Processor #5583

Closed
Leonardo-Ferreira opened this issue Apr 30, 2024 · 4 comments
Closed

Metrics Processor #5583

Leonardo-Ferreira opened this issue Apr 30, 2024 · 4 comments
Labels
await-spec enhancement New feature or request

Comments

@Leonardo-Ferreira
Copy link

Feature Request

Is your feature request related to a problem?

Yes, I would like to filter metrics. For example, I would like to FILTER OUT metrics that are zero-ed, like "You received zero http requests" or "Your Http queue is zero"

Describe the solution you'd like:

builder.Services.AddOpenTelemetry()
     .ConfigureResource(cfg => cfg.AddAttributes(resourceAttributes))
     .WithMetrics(builder => builder.AddAspNetCoreInstrumentation()
          .AddRuntimeInstrumentation()
          .AddProcessInstrumentation()
       ***.AddPROCESSOR<MyCustomProcessor>()***

Additional Context

Having fine grain control over metric beings reported is very useful, specially if you are using solutions that charge you based on the volume of data you report

@Leonardo-Ferreira Leonardo-Ferreira added the enhancement New feature or request label Apr 30, 2024
@cijothomas
Copy link
Member

As mentioned in this doc, the notion of Metrics/MeasurementProcessor does not exist in OpenTelemetry specification. However, a new concept for Filtering is now an experimental spec. This repo has not implemented that capability yet, but hopefully that is what you are looking for.

@Leonardo-Ferreira
Copy link
Author

yeah, that's close to what im looking for... I don't think that spec allows for filtering based on the value of the metric

@Leonardo-Ferreira
Copy link
Author

I created a PR: open-telemetry/opentelemetry-specification#4025

@cijothomas
Copy link
Member

yeah, that's close to what im looking for... I don't think that spec allows for filtering based on the value of the metric

I don't think that is what you need. I left comments in the spec PR asking for more clarification.

@reyang reyang closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
await-spec enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants