Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HTTP Client Request/Response Body Size Metrics #1760

Open
ilhesam opened this issue Mar 23, 2024 · 1 comment
Open

Support for HTTP Client Request/Response Body Size Metrics #1760

ilhesam opened this issue Mar 23, 2024 · 1 comment
Labels
comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http enhancement New feature or request

Comments

@ilhesam
Copy link

ilhesam commented Mar 23, 2024

Hi dears,
I'm proposing the addition of instrumentation to measure HTTP client request and response body sizes, as outlined in the OpenTelemetry semantic conventions for HTTP metrics. These metrics are crucial for understanding the data volume being transferred, aiding in performance optimization and monitoring.

  • The metrics would help identify data transfer spikes and potential bottlenecks.
  • This aligns with OpenTelemetry's semantic conventions, ensuring consistency across implementations.

Is this feature aligned with the project's roadmap?
Any specific implementation preferences or requirements from the maintainers?

I am eager to contribute to the development of this feature. With experience in .NET and open-source contributions, I'm ready to collaborate to bring this to fruition.

Looking forward to your feedback and the possibility of contributing to this enhancement.
Best,
Hesam

@ilhesam ilhesam added the enhancement New feature or request label Mar 23, 2024
@martinjt
Copy link
Member

So this is currently an Experimental spec for those stats. So it's a little more interesting of a requirement.

Ultimately, those should come from runtime, but I have no idea whether they'll be doing them in .NET 9 or not since we have no timeline as to when they'll be stable in Otel.

I think it would be interesting to see what the implementation would look like, but it would need to be behind an experimental flag. There is also the issue that it could be a performance issue.

I don't see a reason we wouldn't accept it as a PR, however, I would say that the bar for performance impact on that would be very high seeing as it's critical path.

As it stands, I don't know anyone working on it, so if you wanted to give it a go, I don't see an issue with that.

@vishweshbankwar vishweshbankwar transferred this issue from open-telemetry/opentelemetry-dotnet May 14, 2024
@Kielek Kielek added the comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants