Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lifts manage their own doors #95

Closed
luca-della-vedova opened this issue Dec 8, 2022 · 0 comments · Fixed by #114
Closed

Make lifts manage their own doors #95

luca-della-vedova opened this issue Dec 8, 2022 · 0 comments · Fixed by #114
Labels
enhancement New feature or request

Comments

@luca-della-vedova
Copy link
Member

Feature request

Description

Make lift simulation plugins manage their own doors, instead of using door plugins.

Implementation considerations

Currently, lift doors are commanded through a door plugin. While this works, the architecture is fundamentally wrong since the simulated lifts will publish a request to the door_supervisor to request opening a lift door, which runs a door plugin.
In reality, lifts would manage their own doors and wouldn't need to go through RMF to operate them.
Additionally, since lift doors are running door plugins they also appear in the rviz door panel, which shouldn't be the case since RMF is not managing the doors individually, i.e. in the hotel world from rmf_demos:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant