Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/form input required #764

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Sep 7, 2023

What's new

Partially fixes #684, schema validation will be considered in our upcoming migration to react-flow.

Checks each task description before allowing submission or scheduling.

image

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #764 (f279f67) into main (58f4869) will decrease coverage by 0.14%.
Report is 1 commits behind head on main.
The diff coverage is 11.32%.

@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
- Coverage   54.20%   54.07%   -0.14%     
==========================================
  Files         263      263              
  Lines        6593     6620      +27     
  Branches      877      879       +2     
==========================================
+ Hits         3574     3580       +6     
- Misses       2879     2900      +21     
  Partials      140      140              
Flag Coverage Δ
dashboard 18.01% <ø> (ø)
react-components 51.64% <11.32%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/react-components/lib/form-inputs.tsx 75.00% <ø> (ø)
...ackages/react-components/lib/tasks/create-task.tsx 4.06% <11.32%> (+1.67%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…or null or empty value

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth mentioned this pull request Sep 8, 2023
5 tasks
Copy link
Collaborator

@Angatupyry Angatupyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Aaron!
LGTM!

@aaronchongth aaronchongth merged commit 8a4415e into main Sep 8, 2023
4 checks passed
@aaronchongth aaronchongth deleted the feature/form-input-required branch September 8, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rmf-web seems unable to verify the submitted task information.
2 participants