Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-components): Task Logs text not updated with Theme - Text not visible in dark mode #650 #653

Closed
wants to merge 1 commit into from
Closed

fix(react-components): Task Logs text not updated with Theme - Text not visible in dark mode #650 #653

wants to merge 1 commit into from

Conversation

koonpeng
Copy link
Collaborator

What's new

Fixes #650

Some of the text are still not very readable, this is a problem with the theme colors.

image

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

fix task logs theming
f35c126 
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
@codecov
Copy link

codecov bot commented Nov 21, 2022 •
edited

Codecov Report

Merging #653 (f35c126) into main (8807bd3) will decrease coverage by 1.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   46.54%   45.29%   -1.25%     
==========================================
  Files         154      155       +1     
  Lines        3139     3294     +155     
  Branches      670      690      +20     
==========================================
+ Hits         1461     1492      +31     
- Misses       1414     1647     +233     
+ Partials      264      155     -109
Flag Coverage Δ
dashboard 26.10% <ø> (-0.17%) ⬇️
react-components 57.59% <ø> (-2.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/react-components/lib/tasks/task-logs.tsx 65.21% <ø> (ø)
...kages/dashboard/src/components/tasks/task-logs.tsx 56.52% <0.00%> (-2.57%) ⬇️
packages/dashboard/src/settings.ts 22.22% <0.00%> (ø)
packages/dashboard/src/components/app.tsx 0.00% <0.00%> (ø)
packages/dashboard/src/components/utils.ts 0.00% <0.00%> (ø)
packages/dashboard/src/components/appbar.tsx 54.00% <0.00%> (ø)
packages/dashboard/src/components/map-app.tsx 0.00% <0.00%> (ø)
packages/dashboard/src/components/app-base.tsx 0.00% <0.00%> (ø)
packages/dashboard/src/components/doors-app.tsx 0.00% <0.00%> (ø)
packages/dashboard/src/components/lifts-app.tsx 0.00% <0.00%> (ø)
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@koonpeng koonpeng closed this Apr 20, 2023
@koonpeng koonpeng deleted the kp/fix-task-log-theming branch April 20, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task Logs text not updated with Theme - Text not visible in dark mode
1 participant
@koonpeng