Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity deadlines cached per course(s) do not account for extensions #243

Open
alexmorrisnz opened this issue Jul 21, 2022 · 1 comment

Comments

@alexmorrisnz
Copy link

In INT-17065 the activity deadlines was changed to cache per course(s), this doesn't account for users with extensions.

To test:

  1. Create a test course with at least two students.
  2. Create an assignment with activity due date 1st August 2022
  3. Log in as student 1, observe due date is correct
  4. Log in as student 2, observe due date is correct
  5. Grant an extension to student 1 for 1st September 2022
  6. Login in as student 1, observe due date is correct (1st September)
  7. Login in as student 2, observe due date is incorrect (should be 1st August)

The cache key should contain the user id, perhaps only if get_user_group_cache_key is empty.

Tested on latest Moodle 3.9 with the theme_snap MOODLE_39_STABLE branch, looks like this could affect master as well though.

@alexmorrisnz
Copy link
Author

alexmorrisnz commented Jul 25, 2022

@xKoetsuji this is similar to #234 which you said is in a backlog
(cc @jgg9026 you look to be the most active recently on snap)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant