Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe separate the riffa driver from clroni #4

Open
aacuevas opened this issue Oct 8, 2021 · 3 comments
Open

Maybe separate the riffa driver from clroni #4

aacuevas opened this issue Oct 8, 2021 · 3 comments

Comments

@aacuevas
Copy link
Collaborator

aacuevas commented Oct 8, 2021

Right now, the clroni nuget package contains both the main libONI library and the onix-specific riffa driver.

Maybe it should be best to have them in separate packages, to ease the introduction of future different drivers, which could then be distributed as individual packages.

Adittionaly, maybe the riffa driver should be renamed as onix-riffa, to make clear that it is part of the ONIX ecosystem.

@jonnew
Copy link
Collaborator

jonnew commented Oct 8, 2021

Although this feels clean, there is a reason why e.g. a FLIR SDK is like 1 GB. They just keep dumping all kinds of hardware compatibility libraries in there so it it always works. I'm a bit weary about dependencies getting stitched together properly

@aacuevas
Copy link
Collaborator Author

You are right. I can also see a dependency issue, like Bonsai.ONIX requiring clroni and a driver but, which driver?
So maybe bundling together the drivers we, as the maintainers, also develop is the best idea.

But we should make sure that any third party can create an onidriver and make it work with clroni without having to go through us.

@jonnew
Copy link
Collaborator

jonnew commented Oct 13, 2021

To the last point -- absolutely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants