Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum frame size is not the minimum BLOCKREADSIZE #11

Open
jonnew opened this issue Jan 23, 2023 · 0 comments
Open

Minimum frame size is not the minimum BLOCKREADSIZE #11

jonnew opened this issue Jan 23, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@jonnew
Copy link
Collaborator

jonnew commented Jan 23, 2023

The frame_size result of

oni_get_opt(ctx, ONI_OPT_MAXREADFRAMESIZE, &frame_size, &frame_size_sz);

cannot be used to set the minimal ONI_OPT_BLOCKREADSIZE via

    oni_size_t block_read_size = frame_size;
    size_t block_size_sz = sizeof(block_read_size);
    rc = oni_set_opt(ctx,
                    ONI_OPT_BLOCKREADSIZE,
                    &block_read_size,
                    block_size_sz);

due to some required overhead. This is not a bug, but something that needs to a least be documented and perhaps requires a utility function to get the correct minimal ONI_OPT_BLOCKREADSIZE.

@jonnew jonnew added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant