Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide classes that result in nodes with more reasonable names #4

Open
jonnew opened this issue Jul 21, 2021 · 2 comments
Open

Provide classes that result in nodes with more reasonable names #4

jonnew opened this issue Jul 21, 2021 · 2 comments

Comments

@jonnew
Copy link
Collaborator

jonnew commented Jul 21, 2021

When helping people with remote installations, the names of nodes used in Bonsai workflows are a source of confusion. For instance, even though a low-level device description might be "FMC Headstage Control Device", there is no reason we to call a corresponding class FMCHeadstageControlDevice. FMC has nothing to do with this. Another example: BNO055 instead of something that describes its function. I would like to brainstorm name replacements below and come up with some sort of unified scheme.

@aacuevas
Copy link
Collaborator

We want to still be able to add new devices that share a functionality (for example different IMUs) so device name should probably part of the class names, maybe something like BNO055IntertialMeasurementUnit .

@jonnew
Copy link
Collaborator Author

jonnew commented Jul 22, 2021

Yes, agree on that. Honestly, an issue here is that the Bonsai workflow editor derives node display names from class names without namespace etc. So we are going to have some long names, like the one you suggest for instance, which I don't love. But the alternative is bad too -- having a node named IMU will of course conflict with something in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants