Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding as a node package #18

Open
Kotarski opened this issue Feb 2, 2020 · 3 comments
Open

Adding as a node package #18

Kotarski opened this issue Feb 2, 2020 · 3 comments

Comments

@Kotarski
Copy link

Kotarski commented Feb 2, 2020

I've been working on a fork to wrap this in javascript to make it into an NPM package (https://github.com/Kotarski/ipa-dict).

Is this something that could be pulled or should I keep it as a fork?

Are you happy for me to submit this to NPM as ipa-dict?

Thanks,

@dohliam
Copy link
Member

dohliam commented Feb 21, 2020

Hi @Kotarski thanks for working on this! Sounds like a great idea to have this available on NPM. The only thing would be keeping it up to date -- there are quite a few issues with some of the experimental data (e.g., in nb, yue, zh) that will be corrected in upcoming commits. Would it be fairly easy to pull those in (perhaps automatically?) when the repo updates?

@Kotarski
Copy link
Author

@dohliam

It should be just a case of pulling the new version as it's just a repo inside. Not sure how I'd go about doing it automatically at the moment but can look into it... maybe the new git workflow stuff will help. Still a bit of work to be done, but I'll continue once I'm back from holiday!

@Kotarski
Copy link
Author

Kotarski commented Jan 8, 2021

I've finally got around to actually doing this over the holidays (https://www.npmjs.com/package/ipa-dict). I've set it up so everything is generated from the data files, so just a pull and republish will update it.

Should we pull the fork back into the main repo, or leave it separate? One benefit of merging it back in is that it could automatically publish when the data changes, but I don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants