Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create micro packages for each dialog & turn Ookii.Dialogs.Wpf into a meta package #28

Open
augustoproiete opened this issue Nov 16, 2020 · 0 comments
Labels
enhancement New feature or request epic
Milestone

Comments

@augustoproiete
Copy link
Member

augustoproiete commented Nov 16, 2020

Now that we are using the SDK-style with multi-targeting and and have a good build pipeline setup, it would be easy to generate separate NuGet packages for each of the dialogs, so that developers can have the option to cherry-pick only the dialogs they want to use in their application.

  • Ookii.Dialogs.Wpf.nupkg, depends on:
    • Ookii.Dialogs.Wpf.TaskDialog.nupkg, depends on:
      • Ookii.Dialogs.Wpf.Core.nupkg, depends on:
        • Ookii.Dialogs.Core.nupkg (no dependencies)
    • Ookii.Dialogs.Wpf.ProgressDialog.nupkg, depends on:
      • Ookii.Dialogs.Wpf.Core.nupkg, depends on:
        • Ookii.Dialogs.Core.nupkg (no dependencies)
    • Ookii.Dialogs.Wpf.CredentialDialog.nupkg, depends on:
      • Ookii.Dialogs.Wpf.Core.nupkg, depends on:
        • Ookii.Dialogs.Core.nupkg (no dependencies)
    • Ookii.Dialogs.Wpf.FolderBrowserDialog.nupkg, depends on:
      • Ookii.Dialogs.Wpf.Core.nupkg, depends on:
        • Ookii.Dialogs.Core.nupkg (no dependencies)
    • Ookii.Dialogs.Wpf.OpenFileDialog.nupkg, depends on:
      • Ookii.Dialogs.Wpf.Core.nupkg, depends on:
        • Ookii.Dialogs.Core.nupkg (no dependencies)
    • Ookii.Dialogs.Wpf.SaveFileDialog.nupkg, depends on:
      • Ookii.Dialogs.Wpf.Core.nupkg, depends on:
        • Ookii.Dialogs.Core.nupkg (no dependencies)

I'm assuming we'll have to create a Ookii.Dialogs.Wpf.Core package to share common WPF code between the different WPF dialog packages, as well as a Ookii.Dialogs.Core package to share common code across both the WPF and WinForms packages (#27).

Turning Ookii.Dialogs.Wpf into a meta package that depends on all other micro packages will provide the same experience that users have today where they'll get all the dialogs with one package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic
Development

No branches or pull requests

1 participant