Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package can't be installed without cuda runtime libraries available #643

Open
DenisKuplyakov opened this issue Feb 15, 2021 · 3 comments · May be fixed by #768
Open

Package can't be installed without cuda runtime libraries available #643

DenisKuplyakov opened this issue Feb 15, 2021 · 3 comments · May be fixed by #768
Labels
triaged Issue has been triaged by maintainers

Comments

@DenisKuplyakov
Copy link

By the moment setup.py script imports onxx_runtime only to extract version information. But this import leads to import of tensorrt, which requires cuda runtime libraries to be available. Thus makes it problematic to build docker images with onxx_runtime inside in CI/CD env without GPUs and cuda runtime.

Some refactoring is required to extract version from package without import of tensorrt, so build in CI/CD without GPU will be possible.

Log when tensorrt is not available on any command requiring setup.py (even not installing)

      ERROR: Command errored out with exit status 1:
       command: /home/dener/.pyenv/versions/eris-ct-worker/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/home/dener/.pyenv/versions/eris-ct-worker/src/onnx-tensorrt/setup.py'"'"'; __file__='"'"'/home/dener/.pyenv/versions/eris-ct-worker/src/onnx-tensorrt/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-ywrl82zv                                                                      
           cwd: /home/dener/.pyenv/versions/eris-ct-worker/src/onnx-tensorrt/                                                                                                                  
      Complete output (11 lines):                                                                                                                                                              
      Traceback (most recent call last):                                                                                                                                                       
        File "<string>", line 1, in <module>                                                                                                                                                   
        File "/home/dener/.pyenv/versions/eris-ct-worker/src/onnx-tensorrt/setup.py", line 18, in <module>                                                                                     
          import onnx_tensorrt                                                                                                                                                                 
        File "/home/dener/.pyenv/versions/3.8.5/envs/eris-ct-worker/src/onnx-tensorrt/onnx_tensorrt/__init__.py", line 23, in <module>                                                         
          from . import backend                                                                                                                                                                
        File "/home/dener/.pyenv/versions/3.8.5/envs/eris-ct-worker/src/onnx-tensorrt/onnx_tensorrt/backend.py", line 22, in <module>                                                          
          from .tensorrt_engine import Engine                                                                                                                                                  
        File "/home/dener/.pyenv/versions/3.8.5/envs/eris-ct-worker/src/onnx-tensorrt/onnx_tensorrt/tensorrt_engine.py", line 21, in <module>                                                  
          import tensorrt as trt                                                                                                                                                               
      ModuleNotFoundError: No module named 'tensorrt'

Log on the situation when there is no cuda runtime available:

    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-rxt1j24m/onnx-tensorrt_12e18d44d1d04b1a975d60ce9c274f9c/setup.py'"'"'; __file__='"'"'/tmp/pip-install-rxt1j24m/onnx-tensorrt_12e18d44d1d04b1a975d60ce9c274f9c/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-crge83fu
         cwd: /tmp/pip-install-rxt1j24m/onnx-tensorrt_12e18d44d1d04b1a975d60ce9c274f9c/
    Complete output (13 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-rxt1j24m/onnx-tensorrt_12e18d44d1d04b1a975d60ce9c274f9c/setup.py", line 18, in <module>
        import onnx_tensorrt
      File "/tmp/pip-install-rxt1j24m/onnx-tensorrt_12e18d44d1d04b1a975d60ce9c274f9c/onnx_tensorrt/__init__.py", line 23, in <module>
        from . import backend
      File "/tmp/pip-install-rxt1j24m/onnx-tensorrt_12e18d44d1d04b1a975d60ce9c274f9c/onnx_tensorrt/backend.py", line 22, in <module>
        from .tensorrt_engine import Engine
      File "/tmp/pip-install-rxt1j24m/onnx-tensorrt_12e18d44d1d04b1a975d60ce9c274f9c/onnx_tensorrt/tensorrt_engine.py", line 22, in <module>
        import pycuda.driver
      File "/usr/local/lib/python3.8/dist-packages/pycuda/driver.py", line 62, in <module>
        from pycuda._driver import *  # noqa
    ImportError: libcuda.so.1: cannot open shared object file: No such file or directory
    ----------------------------------------
@DenisKuplyakov
Copy link
Author

Related issue from SO: https://stackoverflow.com/questions/2058802/how-can-i-get-the-version-defined-in-setup-py-setuptools-in-my-package

@kevinch-nv
Copy link
Collaborator

What version of ONNX-TRT are you using? Is this reproducible on master?

@DenisKuplyakov
Copy link
Author

I were using 21.02 tag when created the issue.

I haven't tried, but I'm sure it is still reproducible on master, as I see that the issue persists in code.

Let me describe step-by-step what happens for more clarity:

  1. You invoke python3 setup.py install to setup package. Moreover here you can invoke any setup.py command (get version, dependencies list, etc.)
  2. python evaluates setup.py script
  3. setup.py imports onnx_tensorrt package here just to get its version here
  4. python processes onnx_tensorrt/__init__.py and imports onxx_tensorrt/backend.py here
  5. python processes onxx_tensorrt/backend.py and imports tensorrt here
  6. tensorrt requires cuda runtime to be imported

So this prevents you on installing package without tensorrt and cuda runtime available. That means you can't build docker image in CI on machine without GPU for further use on machines with GPU. Also you can't do dependency management or use any setup.py features without trt and cuda runtime.

By the moment I have ugly hacks in my Dockerfiles to solve the problem:

        git clone --depth 1 --branch 21.02 \
            https://github.com/onnx/onnx-tensorrt.git && \
        cd onnx-tensorrt && \
        cp -r onnx_tensorrt /usr/local/lib/python3.8/dist-packages && \
        cd .. && \
        rm -rf onnx-tensorrt; \

To solve the issue, as I said above, refactoring is required to extract version from package without import of tensorrt. Here is more info on how to handle python package versioning correctly.

@RuRo RuRo linked a pull request Oct 26, 2021 that will close this issue
Open
@kevinch-nv kevinch-nv added the triaged Issue has been triaged by maintainers label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged Issue has been triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move the version to setup.py RuRo/onnx-tensorrt
2 participants
@DenisKuplyakov @kevinch-nv