Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Please consider refactoring Bonjour class. #4

Open
pcafstockf opened this issue Aug 13, 2021 · 1 comment
Open

Feature Request: Please consider refactoring Bonjour class. #4

pcafstockf opened this issue Aug 13, 2021 · 1 comment

Comments

@pcafstockf
Copy link

pcafstockf commented Aug 13, 2021

Editing this request as my understanding of multicast-dns (and by extension bonjour-service) has improved.

It's helpful that the Server class exposes the global multicast-dns instance, but it would also be good if that same paradigm extended to the Bonjour class (exposing it's server and registry properties maybe as readonly).

It might also be a good time to make destroy an idempotent operation.

@mdidon
Copy link
Member

mdidon commented Oct 19, 2021

We're looking to do a rewrite with v2 of the project after using the module in some of our in house projects.
Improving the destroy operation is high on the list of priorities.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants