Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The type of "options" in the Bonjour constructor is incorrect #10

Open
RohdeWW opened this issue Jan 28, 2022 · 1 comment
Open

The type of "options" in the Bonjour constructor is incorrect #10

RohdeWW opened this issue Jan 28, 2022 · 1 comment

Comments

@RohdeWW
Copy link

RohdeWW commented Jan 28, 2022

The options parameter is specified to have the type ServiceConfig:

constructor(opts?: ServiceConfig | undefined) {

However, this parameter is passed directly to the multicast-dns server which has a very different type for its options.
{
multicast: true // use udp multicasting
interface: '192.168.0.2' // explicitly specify a network interface. defaults to all
port: 5353, // set the udp port
ip: '224.0.0.251', // set the udp ip
ttl: 255, // set the multicast ttl
loopback: true, // receive your own packets
reuseAddr: true // set the reuseAddr option when creating the socket (requires node >=0.11.13)
}

@mdidon
Copy link
Member

mdidon commented May 4, 2022

@RohdeWW Noted, we'll have a look how is best to proceed to avoid break changes for users.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants