Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rainbow mode expansion (feature) #394

Open
Rodrix33333 opened this issue Oct 27, 2022 · 13 comments
Open

Rainbow mode expansion (feature) #394

Rodrix33333 opened this issue Oct 27, 2022 · 13 comments
Labels
enhancement New feature or request

Comments

@Rodrix33333
Copy link

Rainbow mode is amazing.

To make it even better I suggest:

  1. be able to change the gradients (so it's just a hue animation of reds, for example. Or a rainbow of fire colors).

Maybe what we actually need to do is to add a new functionality to gradients: time and scale for the animation.

  1. to make the speed time factor, change depending on how many notes are pressed.
@Rodrix33333
Copy link
Author

Let me rewrite this:

  1. add time and scale to gradient mode.
  2. add the possiblity of multi point gradients.

That's all we need. No need to touch the rainbow mode.

@Nbobito
Copy link
Contributor

Nbobito commented Oct 28, 2022

What if there was a way to create custom animations and gradients? They could be created using some tool in the web interface, then saved as an animation file.

@Rodrix33333
Copy link
Author

No need to have animation files, I believe. Multi point gradients would be enough. As a setting.

What type of animations do you have in mind. I am interested

@onlaj onlaj added the enhancement New feature or request label Oct 28, 2022
@onlaj
Copy link
Owner

onlaj commented Oct 28, 2022

add the possiblity of multi point gradients.

That I can do. I think SeeMusic has this feature too, so it will work great together.

@onlaj
Copy link
Owner

onlaj commented Nov 2, 2022

@Rodrix33333 @Nbobito
Instead of adding new color mode I added gradient to already existing Multicolor.
You add gradient by NOT assigning range. Instead of not lighting keys it takes the closest colors from left and right and mix them together creating a gradient.

ZYIdtPI

PXL_20221102_112150524

Branch, if you want to test it before merging: 43aa882

@Rodrix33333
Copy link
Author

Looking great!!! Do you think you can add the time animation feature (as in Rainbow)? Could be 0 for no animation. Looking forward to testing it!

@Rodrix33333
Copy link
Author

It's looking great! Could you add the time feature for the multicolor?

@Rodrix33333
Copy link
Author

Time and scale

@onlaj
Copy link
Owner

onlaj commented Nov 8, 2022

Time, maybe. But why scale?

@onlaj
Copy link
Owner

onlaj commented Nov 8, 2022

Nvm, I thought about it for a while and I can see some use cases. Added to to-do list.

@Rodrix33333
Copy link
Author

Rodrix33333 commented Nov 8, 2022 via email

@rodrix385
Copy link

I am back!!! I am looking forward to expanding your source code. Are you still active? :)

@onlaj
Copy link
Owner

onlaj commented Apr 27, 2023

Yes, but my RPi is fried and I still didn't buy new one, so I can't make any tests. I will try to find some replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants