Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.6.1: onionshare depends on onionshare_cli but also conflicts with onionshare_cli #1878

Open
kpcyrd opened this issue Feb 25, 2024 · 0 comments

Comments

@kpcyrd
Copy link

kpcyrd commented Feb 25, 2024

Trying to install wheels for both onionshare and onionshare_cli at the same time causes an error:

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/lib/python3.11/site-packages/installer/__main__.py", line 98, in <module>
    _main(sys.argv[1:], "python -m installer")
  File "/usr/lib/python3.11/site-packages/installer/__main__.py", line 94, in _main
    installer.install(source, destination, {})
  File "/usr/lib/python3.11/site-packages/installer/_core.py", line 87, in install
    record = destination.write_script(
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/installer/destinations.py", line 230, in write_script
    entry = self.write_to_fs(
            ^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/installer/destinations.py", line 167, in write_to_fs
    raise FileExistsError(message)
FileExistsError: File already exists: /build/onionshare/pkg/onionshare/usr/bin/onionshare-cli

However it doesn't seem like onionshare (desktop) is a replacement for onionshare_cli, it specifically uses import onionshare_cli, implying both need to be installed for the desktop app to work.

To fix this, desktop/pyproject.toml should contain

[tool.poetry.scripts]
onionshare = 'onionshare:main'

instead of

[tool.poetry.scripts]
onionshare = 'onionshare:main'
onionshare-cli = 'onionshare_cli:main'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant