Skip to content
This repository has been archived by the owner on Apr 28, 2022. It is now read-only.

Amazon: Billing request handling must be blocking #29

Open
RomanZhilich opened this issue Aug 4, 2015 · 2 comments
Open

Amazon: Billing request handling must be blocking #29

RomanZhilich opened this issue Aug 4, 2015 · 2 comments

Comments

@RomanZhilich
Copy link
Collaborator

AmazonBilling provider uses Service\BroadcastReceiver flow to handle requests. Current implementation is a little bit unreliable and somewhat confusing - there's no way to distinguish one purchase response from another.

Best way to workaround it is probably make billing request handling a blocking operation. However Amazon doesn't guarantee callback after posted request - there should be some failsafe so library won't get stuck waiting for callback that will never arrive.

Solution likely requires quite a bit of decompiled code reading.

@mikemee
Copy link

mikemee commented Sep 16, 2015

Any idea if this is likely to be a real-world problem for an Amazon store app that has simple "BUY" buttons for non-consumables, i.e. where the customer will rarely tap more than one, and when they do, they will at a minimum be 10-60 seconds apart?

Or, similarly, could it be a problem after re-installing the app and having a group of (say 10) previous purchases restored?

I.e., I'm trying to work out if this issue should block me trying to use it on Amazon with my quite simple IAP needs? Thanks in advance for any insight!

@RomanZhilich
Copy link
Collaborator Author

Current implementation works fine.

This enhancement is intended to make Amazon purchase flow more like other BillingProviders. Potentially it will allow to simplify library architecture and add getSku() API to BillingResponse.

Any idea if this is likely to be a real-world problem for an Amazon store app that has simple "BUY" buttons for non-consumables

No, it's not likely.

@RomanZhilich RomanZhilich removed their assignment Feb 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants