Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Ruby 3.1 - Open3 #capture2 causes IRB console to become unresponsive #288

Open
johnnyshields opened this issue Jun 26, 2022 · 16 comments

Comments

@johnnyshields
Copy link

johnnyshields commented Jun 26, 2022

I have also filed a ticket with ruby/open3 repo here: ruby/open3#9, but this seems more like a Windows-specific issue as it works on Linux/Mac.

The following script will cause IRB console to become unresponsive on Ruby 3.1 on Windows installed by the Windows Ruby Installer x64-mingw-ucrt. This is using the version of Open3 packaged with Ruby (0.1.1)

$> irb

require 'open3'
Open3.capture2('ver')

# after this, the IRB console becomes unresponsive
@johnnyshields johnnyshields changed the title Open3 #capture2 causes IRB console to become unresponsive on Windows Ruby 3.1 Windows Ruby 3.1 - Open3 #capture2 causes IRB console to become unresponsive Jun 26, 2022
@mohits
Copy link
Collaborator

mohits commented Jun 26, 2022

Hi @johnnyshields - I did a quick check with your sample on my side, and it seems to work as expected. This is in the Windows console (cmd).

$ ruby -v
ruby 3.1.1p18 (2022-02-18 revision 53f5fc4236) [x64-mingw-ucrt]

$ irb
irb(main):001:0> require 'open3'
=> true
irb(main):002:0> Open3.capture2('ver')
=> ["\nMicrosoft Windows [Version 10.0.19044.1766]\n", #<Process::Status: pid 13272 exit 0>]
irb(main):003:0> (0..2).each {|x| puts "Hello #{x}"}
Hello 0
Hello 1
Hello 2
=> 0..2
irb(main):004:0> exit

Just adding this here in case it helps to debug what the difference might be.

@johnnyshields
Copy link
Author

johnnyshields commented Jun 26, 2022

@mohits thanks for checking this, this is very useful. Hmmm very strange. Possibly something specific to my system.

Quite bizarre tho as Ruby 3.0 and earlier don't have the same issue.

@mohits
Copy link
Collaborator

mohits commented Jun 26, 2022

@johnnyshields - I checked both Ruby 3.0 and Ruby 3.1 on my system (though I only posted the result from 3.1) and both worked fine. The installation is also bog-standard - https://notepad.onghu.com/2022/ruby3.1-windows-day0-install-hello_world/ - nothing special in it.

@johnnyshields
Copy link
Author

johnnyshields commented Jun 26, 2022

@mohits I appreciate it.

@MSP-Greg
Copy link
Contributor

The following script will cause IRB console to become unresponsive on Ruby 3.1

Testing with Ruby 3.1.2 and Ruby master (ruby 3.2.0dev (2022-06-26T02:16:11Z master a782d76fbe) [x64-mingw-ucrt]), I have the same result.

@P3t3rU5
Copy link

P3t3rU5 commented Jan 1, 2023

same is happening to me and it is making nokigiri installation fail

> gem install nokogiri
Temporarily enhancing PATH for MSYS/MINGW...
Building native extensions. This could take a while...
#<Thread:0x0000013ef5ede448 C:/Programming/Ruby/rubyinstaller-3.2.0-1-x64/lib/ruby/3.2.0/open3.rb:404 run> terminated with exception (report_on_exception is true):
C:/Programming/Ruby/rubyinstaller-3.2.0-1-x64/lib/ruby/3.2.0/open3.rb:404:in `read': stream closed in another thread (IOError)
        from C:/Programming/Ruby/rubyinstaller-3.2.0-1-x64/lib/ruby/3.2.0/open3.rb:404:in `block (2 levels) in capture2e'
ERROR:  Interrupted

@ccmywish
Copy link

ccmywish commented Jan 11, 2023

Test report: gem install nokogiri on Windows 11 (10.0.22621.1105) with Ruby 3.2.0-1 works fine.

I think this may relate to some specific Windows versions.

@P3t3rU5
Copy link

P3t3rU5 commented Jan 19, 2023

Seems like MSYS was the issue here - installed on top of my previous installation and it started working

@P3t3rU5
Copy link

P3t3rU5 commented Jan 20, 2023

nevermind... seemed to work but when doing bundler update it gets stuck trying to install nokogiri

@johnnyshields
Copy link
Author

This issue is still persisting with the officially released Windows RubyInstaller for Ruby 3.2.0

@OursCodeur
Copy link

Hey, I can confirm I have the issue as well here - Windows 11 [Version 10.0.22621.1702] and ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x64-mingw-ucrt] .

@MSP-Greg
Copy link
Contributor

Not sure if this is an Open3 issue, as the following work. Might be an irb issue?

ruby -e "require 'open3'; puts Open3.capture2('ver')"
ruby -e "require 'open3'; Thread.new { puts Open3.capture2('ver') }.join"

@OursCodeur
Copy link

OursCodeur commented May 15, 2023

What started the investigation on my side was using mjml-rails in a regular project on Windows - which relies on Open3 to run MJML itself (here). Capture3 causes ruby to hang up indefinitely, which I can reproduce in irb.

I can also confirm @MSP-Greg 's commands do not cause the issue.

Hope the additional context helps somehow.

@johnnyshields
Copy link
Author

johnnyshields commented May 15, 2023 via email

@OursCodeur
Copy link

Trying to work my way around Open3, I've also been able to reproduce the IRB hang with systemu('env') .

@johnnyshields
Copy link
Author

FYI this issue still happens on Windows Ruby Installer for Ruby 3.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants