Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure when private repos are omitted #15

Open
AndyCGYan opened this issue Jul 19, 2021 · 2 comments
Open

Build failure when private repos are omitted #15

AndyCGYan opened this issue Jul 19, 2021 · 2 comments

Comments

@AndyCGYan
Copy link

As public builders, we need to exclude private repos per manfiest readme. However, Settings still refer to it and will therefore fail to build:
error: packages/apps/Settings/Android.bp:22:1: module "Settings-core" variant "android_common": module source path "packages/apps/Settings/OmniGears/res" does not exist
IMO, the whole private repo scheme should be redesigned backwards, i.e. by default public builders can sync and build out of the box, and the privileged few can do extra steps to authenticate and get them.
@aczire
Copy link

aczire commented Aug 12, 2021

s of now without access to the private repositories OmniRom build is not possible due to this issue.
Is there a workaround for it?

@AndyCGYan
Copy link
Author

s of now without access to the private repositories OmniRom build is not possible due to this issue.
Is there a workaround for it?

I see what you meant - go to the offending file and remove the dependency on private stuff. I don't build Omni now so I don't know how much there is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aczire @AndyCGYan