Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'tests' folder is included in pyformance python package #75

Open
theakshaypilania opened this issue Sep 3, 2020 · 1 comment
Open

Comments

@theakshaypilania
Copy link

Hi,
'tests/' folder and its contents are included in the python package and are also installed when pyformance package is installed via pip. This is a major issue as it breaks the local test import of various clients of pyformance as python tries to look for tests in site packages first and this breaks the code of clients i.e. you cannot do 'import tests.' in your code anymore as your tests folder would never be looked instead pyformance's tests folder would be looked first.
Please exlude tests/ folder from setup.py of pyformance to rectify this issue.

Solution 1)
You can replace your package line like this in setup.py:
packages=find_packages(exclude=['tests*'])

Solution 2)
remove init.py from tests/ folder so that it becomes a normal directory and not a python package to exclude from pip install.

@rxt1077
Copy link

rxt1077 commented May 4, 2021

Can confirm, just encountered this issue myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants