Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartThingsTV pypi module #304

Open
starkillerOG opened this issue Feb 18, 2024 · 3 comments
Open

SmartThingsTV pypi module #304

starkillerOG opened this issue Feb 18, 2024 · 3 comments

Comments

@starkillerOG
Copy link

Would you consider publishing the code under custom_components/samsungtv_smart/api/smartthings.py as a pypi module so that other projects can use the SmartThingsTV class?

If not, do you mind if I fork and publish it myself as a pypi module?

I want to get basic smartthings support inside the HomeAssistant samsungtv component to get some missing features in the build-in integration.

@ollo69
Copy link
Owner

ollo69 commented Feb 18, 2024

@starkillerOG,

this is in my plan, I will do this shortly.
But consider that add SmartThings support to native SamsungTV integration was already discussed in the past, the point was that HA teams don't want to have "hybrid" integration that works both local and cloud based. I don't know if somethink is changed, honestly I don't think.

@starkillerOG
Copy link
Author

@ollo69 good to know, thanks!
I will ask around if it "hybrid" would be acceptable.

@starkillerOG
Copy link
Author

@ollo69 I discussed this with HomeAssistant core, and they will allow us to implement SmartThings cloud into the buildin samsungtv integration to extend the features.

However cloud needs to be optional and cloud should only be used for features that are not locally available.

So we can defenitly work on this.

If you get the pypi module published we can then start working on a first implementation for the buildin integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants