Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtualized SwipeableViews: Redundant transition when reaching the overscan limit while swiping with arrow keys #656

Open
m-shojaei opened this issue Dec 30, 2021 · 0 comments
Open

Virtualized SwipeableViews: Redundant transition when reaching the overscan limit while swiping with arrow keys #656

m-shojaei opened this issue Dec 30, 2021 · 0 comments

Comments

@m-shojaei
Copy link

m-shojaei commented Dec 30, 2021 •
edited

When swiping with the keyboard after interacting with a button in a slide there will be a transition in the opposite direction when reaching the overscan limit from the origin slide with the button.

Expected Behavior

There shouldn't be an extra redundant transition when reaching the overscan limit

Steps to Reproduce (for bugs)

https://codesandbox.io/s/virtualized-swipeableviews-transition-issue-dzct7?file=/demo.js

  1. Press on the button in the first slide
  2. Swipe 2 times to the right with the arrow keys. (notice that I have set the overscanSlideBefore and overscanSlideAfter to 1)
  3. You will notice a transition effect in the opposite direction of your swiping.

Your Environment

Tech Version
react-swipeable-views 0.14.0
React 17.0.2
platform Chrome
@m-shojaei m-shojaei changed the title Virtualized SwipeableViews: Redundant transition when reaching the overscan limit when swiping with arrow keys Virtualized SwipeableViews: Redundant transition when reaching the overscan limit while swiping with arrow keys Dec 30, 2021
m-shojaei added a commit to TouchtechAB/react-swipeable-views that referenced this issue Jan 5, 2022
@m-shojaei
fixed a check in transitionListener handler ...
2ccb2b7 
that was causing extra transition effects when interacting with other elements with transition styles in a slide.
oliviertassinari#656
This was referenced Jan 5, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the check in transitionListener handler ... TouchtechAB/react-swipeable-views
1 participant
@m-shojaei