Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRASH] When ripple deleting in certain circumstances #2233

Open
jazztickets opened this issue Jun 1, 2023 · 2 comments · May be fixed by #2310
Open

[CRASH] When ripple deleting in certain circumstances #2233

jazztickets opened this issue Jun 1, 2023 · 2 comments · May be fixed by #2310
Labels
Crash Unexpected termination or freeze of Olive Triage This issue is yet to be triaged

Comments

@jazztickets
Copy link
Contributor

Commit Hash
70690c5

Platform
Arch Linux

Summary
I've found that when ripple deleting a few clips (possibly involving cross fades or text nodes), olive crashes.

Steps to Reproduce

  1. Create a few clips on the timeline, and add text nodes and/or crossfades between them
  2. Highlight some of the clips at the beginning, but not all clips
  3. Shift+delete to ripple delete.

Here's one scenario that crashes:
2023-05-31_20-21

Crash Report


Additional Information

I loaded up Olive in a debugger and it turns out the track variable is null on line 390:

Track *track = region.first;

Adding something like this fixes the crashes:

    Track *track = region.first;
    if(!track) {
      qWarning() << "Track is null!";
      continue;
    }

If it's not supposed to be null, then we got other problems but it's a good idea to check for null here in any case.

@jazztickets jazztickets added Crash Unexpected termination or freeze of Olive Triage This issue is yet to be triaged labels Jun 1, 2023
@Awesomeplayer98
Copy link

I get this same issue. It's definitely related to cross fades.

@ThomasWilshaw
Copy link
Collaborator

If you can confirm it's realated to transitions see #1842

@jazztickets jazztickets linked a pull request Feb 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crash Unexpected termination or freeze of Olive Triage This issue is yet to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants