Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Unsupported Game Versions #77

Closed
FoxbitDreamtail opened this issue May 4, 2024 · 6 comments
Closed

Hide Unsupported Game Versions #77

FoxbitDreamtail opened this issue May 4, 2024 · 6 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@FoxbitDreamtail
Copy link

FoxbitDreamtail commented May 4, 2024

as the name suggests, would it not be possible to just use the java runtime that the launcher started with for minecraft and if the java version is incompatible with say java 8 classes then should the game versions not be hidden behind a toggle where you would need to specify or allow to download a copy of java 17(specifically for x64 computers)?

@bigfoot547
Copy link
Member

would it not be possible to just use the java runtime that the launcher started with for minecraft

not necessarily

if the java version is incompatible with say java 8 classes then should the game versions not be hidden behind a toggle where you would need to specify or allow to download a copy of java 17

that's not really necessary because the launcher will already download the appropriate java runtime from Mojang as necessary. There's also not really a way to tell the version of the java runtime if it is specified explicitly in the profile settings, so the launcher can't actually determine class file version compatibility. It only knows what java version should be downloaded for a specific version of the game.

@FoxbitDreamtail
Copy link
Author

FoxbitDreamtail commented May 14, 2024

then why not use that information to limit the supplied options for unsupported Operating systems? Windows xp for example never supported java 17 so it would be safe to hide all minecraft versions that rely on java 17 or above in windows xp. (have an option in settings to Enable Unsupported Game Versions

@bigfoot547
Copy link
Member

bigfoot547 commented May 14, 2024

I don't have a matrix of java version support versus operating system version. Also, it's not like "windows XP doesn't support java 17", it's just that you haven't yet found a Java 17 VM that runs on windows XP. What if there's just a super obscure one that you haven't found yet?

@FoxbitDreamtail
Copy link
Author

You know that instead of just saying random things you can actually back up your point and prove it, find a Java 17 version that works with Windows XP service pack 3, I dare you. If you can't, then stop spouting nonsense. As far as anyone here is concerned there is no such thing as a version of java 17 or Java 21 for that matter that supports Windows XP service pack 3 x86.

@bigfoot547 bigfoot547 added enhancement New feature or request wontfix This will not be worked on labels May 21, 2024
@bigfoot547 bigfoot547 closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
@bigfoot547
Copy link
Member

This feature would introduce an annoying maintenance burden which simply is not worth the effort.

@bigfoot547
Copy link
Member

then stop spouting nonsense

#82 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants