Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Buttons do not pass colour contrast accessibility #81

Open
stevensimon opened this issue Jan 23, 2015 · 5 comments
Open

Open Buttons do not pass colour contrast accessibility #81

stevensimon opened this issue Jan 23, 2015 · 5 comments

Comments

@stevensimon
Copy link

http://opendefinition.org/buttons/

The "blue" and orange/grey buttons do not pass WCAG 2.0 colour contrast minimums. Please see improved versions attached (sorry, I'd submit a pull request but I can't find where these images are in a repo, only on the assets server of okfn...)

oc_80x15_blue
oc_80x23_blue
od_80x15_blue
od_80x23_blue
ok_80x15_blue
ok_80x15_orange_grey
ok_80x23_blue
os_80x15_blue
os_80x15_orange_grey

@mlinksva
Copy link
Contributor

Thanks for this. I don't know if there's a public repo for the OK assets server. I'll try bringing this issue to attention of sysadmins who have resolved previous issues with the site.

@nigelbabu
Copy link

These buttons are hosted on S3, but version controlled on this bitbucket repo. If you can submit a pull request there, we can accept it and do the sync. Does that sound okay?

@stevensimon
Copy link
Author

That sounds ok :) Will do so soonish! Noticed a few other buttons that may need tweaking so will add them in as well. Thanks for informing me of the bitbucket repo

@rufuspollock
Copy link
Member

@stevensimon how are you doing on the pull requests. I'm also wondering whether we move those specific buttons here ... (i.e. to this repo)

@stevensimon
Copy link
Author

@rgrp I never got around to using the bitbucket repo unfortunately... my employment finished up early this year and I lost all access to my old email (bitbucket creds were in there) and honestly, have been out of the industry since. I don't mind doing the rest of the buttons up, shouldn't take too long. I'll leave it up to you whether to move them into this repo or you can add them into the bitbucket repo yourself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants