New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files not supported by the ODE #316
Comments
@romicolman |
Hello, I think I need a more specific instruction here. How/Where is the message: |
@guergana you'll find a list of supported data formats by the Frictionless-py here: https://framework.frictionlessdata.io/ |
@guergana you can add a pop-up window to inform the user that the file is not supported by the tool. Message: Your file is not supported by this tool Supported data formats: CSV, XLS, JSON, SQL Let me know if you have further questions |
Hi, I do have questions @romicolman I tried importing the files I had at hand and they are the ones from the repository itself. They are code so they are all text files and all of them are opened by the editor. One of these files is a yaml file... In the link to the frictionless api docs provided by Sara, it says Another thing is that the add button lets the user adds several files.. What do we do in the case the user tries to add a file with a valid extension and one with an unsupported extension? Do we send the message and dont import any of the files? or do we import the files with the supported extension? |
@romicolman For example, consider a simple projects having:
There is no view available for |
@sapetti9 |
Files support:
|
|
Answers below
Do we need to include paper.pdf? This is not tabular data but I wonder if you mention it for some specific reason. What about ? 2)" Another thing is that the add button lets the user adds several files.. What do we do in the case the user tries to add a file with a valid extension and one with an unsupported extension? Do we send the message and dont import any of the files? or do we import the files with the supported extension?"
|
@romicolman moving back to Backlog because the solution is to add all the files, right? and it's not part of the sprint. |
Yes, we will add all files. Let's discuss this in the planning meeting today. |
And then the message displayed in the viewer stays the same as now or do we update it ? In case we update it which would be the new message? @romicolman The one now is |
Note, that the list from Frictionless Framework includes not only tabular formats, and a format needs to be enabled in Open Data Editor separately - https://github.com/okfn/opendataeditor/blob/main/pyproject.toml#L5 (currently, we support CSV/Excel/JSON/Parquet) |
Problem description
When you upload a file that is not supported by the ODE, you get the following message on the ODE screen:
Steps to reproduce it
Suggested solution
Whenever you upload a file not supported by the ODE you should get this message:
Your file is not supported by this tool
The text was updated successfully, but these errors were encountered: