misleading label in Notification form

[viktor-c]

What's this issue about?

When using notifications I get a Hint stating "You can also use MJML</u> to create your email templates"

Expected behavior

I expect to type a string as a body and see it in the received email

Actual behavior

"context":"SubmissionSetFieldService","submission":6,"form":2,"error":{"name":"Error","message":"Parsing failed. Check your mjml.","stack":"Error: Parsing failed. Check your mjml.\n    at MJMLParser (/usr/src/api/node_modules/mjml-parser-xml/lib/index.js:340:11)\n    at mjml2html (/usr/src/api/node_modules/mjml-core/lib/index.js:224:39)\n    at /usr/src/api/dist/service/submission/submission.notification.service.js:39:49\n    at Array.map (<anonymous>)\n    at SubmissionNotificationService.process (/usr/src/api/dist/service/submission/submission.notification.service.js:30:57)\n    at SubmissionSetFieldService.finishSubmission (/usr/src/api/dist/service/submission/submission.set.field.service.js:78:28)\n    at async SubmissionFinishMutation.submissionFinish (/usr/src/api/dist/resolver/submission/submission.finish.mutation.js:32:9)\n    at async target (/usr/src/api/node_modules/@nestjs/core/helpers/external-context-creator.js:77:28)\n    at async Object.submissionFinish (/usr/src/api/node_modules/@nestjs/core/helpers/external-proxy.js:9:24)"},"msg":"failed to send notifications"}

When a mjml template is used I get 2 identical notifications. When notifications are not setup, I get no notification at all.

Steps to reproduce

Install the latest ohmyform docker image, then setup a form and enable notifications.

Environment

Ubuntu 20.04, latest ohmyform docker image.

[viktor-c]

The hint is misleading, the code is also not robust enough.
When notifications are sent, there is no logging for it; when an error occurs I get some logging.

Logging for sent email does occur
context":"MailService","email":"****@example.com","template":"user/created","language":"en","msg":"sent email"}
But no logging on sending submissions.

I think this occurs because
user.create.service.ts uses import { MailService } from '../mail.service'
but
submission.notification.service.ts uses import { MailerService } from '@nestjs-modules/mailer'

So emails are sent in 2 inconsistent ways throughout the code.