You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That was only introduced in fish 2.3.0 (and it's possible this specific usage only worked in an even later version), which means this won't work in fish 2.2.0 - unlike the badge in the README claims.
It is possible to replace this with grep, but frankly, given that fish 2.3.0 is 7 years old, and that 67% of all commits to fish happened since then, I don't believe it is a good use of the already very limited time of the omf contributors.
Specifically, this will be awkward to new contributors because they'll very likely not know how to support a version that old, and how you would write good fish script has changed a fair bit since then - string, argparse, math, ...
So I would suggest increasing the minimum supported version. See repology for which fish versions are in use by distributions, where you'll find very few still in-support versions that have fish < 3.0.
And see this handy table for how many commits there have been since each release (excluding patch releases):
release
commits since the previous
percent of commits to 3.6.1 missing
number of commits missing
release date
3.6.1
129
0%
0
2023-03-25
3.6.0
780
0.8%
129
2023-01-07
3.5.0
433
5.6%
933
2022-06-16
3.4.0
1106
8.2%
1375
2022-03-12
3.3.0
435
15%
2504
2021-06-28
3.2.0
2177
18.1%
3028
2021-03-01
3.1.0
2210
31.6%
5296
2020-02-12
3.0.0
1808
45.2%
7576
2018-12-28
2.7.0
418
56.1%
9387
2017-11-23
2.6.0
410
58.6%
9805
2017-06-03
2.5.0
350
61%
10215
2017-02-03
2.4.0
673
63.1%
10565
2016-11-08
2.3.0
801
67.4%
11292
2016-05-20
2.2.0
1301
72.2%
12093
2015-07-06
The text was updated successfully, but these errors were encountered:
The main repository seems abandoned for the last couple of years:
https://github.com/oh-my-fish/oh-my-fish
According to this [issue](oh-my-fish/oh-my-fish#934)
written by faho – one of the top contributors to fish shell itself –
Oh My Fish doesn't support the latests versions anymore.
Goodbye.
Since 029a675, this uses the
string
builtin in omf.packages.install:https://github.com/oh-my-fish/oh-my-fish/blame/d427501b2c3003599bc09502e9d9535b5317c677/pkg/omf/functions/packages/omf.packages.install.fish#L22
That was only introduced in fish 2.3.0 (and it's possible this specific usage only worked in an even later version), which means this won't work in fish 2.2.0 - unlike the badge in the README claims.
It is possible to replace this with
grep
, but frankly, given that fish 2.3.0 is 7 years old, and that 67% of all commits to fish happened since then, I don't believe it is a good use of the already very limited time of the omf contributors.Specifically, this will be awkward to new contributors because they'll very likely not know how to support a version that old, and how you would write good fish script has changed a fair bit since then -
string
,argparse
,math
, ...So I would suggest increasing the minimum supported version. See repology for which fish versions are in use by distributions, where you'll find very few still in-support versions that have fish < 3.0.
And see this handy table for how many commits there have been since each release (excluding patch releases):
The text was updated successfully, but these errors were encountered: