Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omf update <plugin> should checkout branch specified in packages-main #905

Open
lythesia opened this issue Jun 17, 2022 · 6 comments
Open

Comments

@lythesia
Copy link

Oh My Fish version:   7
OS type:              Darwin
Fish version:         fish, version 3.4.1
Git version:          git version 2.32.1 (Apple Git-133)
Git core.autocrlf:    no
Checking for a sane environment...
Your shell is ready to swim.

and errors

~ » omf update colored-man-pages
Updating https://github.com/oh-my-fish/packages-main master... Done!
fatal: couldn't find remote ref refs/heads/master
Could not update colored-man-pages.

same as #872 , and suspect the master/main branch naming
Also tried remove and install, and then omf update still produce this error

@scorphus
Copy link
Member

Unfortunately, the theme author decided to change the default branch form master to main.

Could you please try uninstalling and reinstalling the plugin?

omf uninstall colored-man-pages
omf install colored-man-pages

Let me know if that works.

@scorphus scorphus changed the title Could not update colored-man-pages omf update <plugin> uses master as branch name regardlessly of packages-main Jun 19, 2022
@scorphus scorphus changed the title omf update <plugin> uses master as branch name regardlessly of packages-main omf update <plugin> should checkout branch specified in packages-main Jun 19, 2022
@lythesia
Copy link
Author

lythesia commented Jun 20, 2022

Also tried remove and install, and then omf update still produce this error

no :(

@tennox
Copy link
Contributor

tennox commented Jun 20, 2022

Same here, and
/etc/fish/omf/pkg/fish-functions -> git remote show origin shows the correct branch:

HEAD branch: main

EDIT
well... I see this issue covers a bit of a different but related issue - I created a separate PR instead:
#908

tennox added a commit to tennox/oh-my-fish that referenced this issue Jun 20, 2022
@scorphus
Copy link
Member

Also tried remove and install, and then omf update still produce this error

no :(

Note: once re-installed there's not need for an update.

@inflation
Copy link

Same issue with PatrickF1/fzf.fish. omf always fetch for master when updating.

scorphus pushed a commit to tennox/oh-my-fish that referenced this issue Oct 2, 2022
@brainz80
Copy link

Having same issue with PatrickF1/fzf.fish and meaningful-ooo/sponge.

Installed them by running omf install https://github.com/PatrickF1/fzf.fish and omf install https://github.com/meaningful-ooo/sponge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants