Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install aborted: /mingw64/bin/git is Git for Windows which is not supported. #897

Open
TheCodeHeist opened this issue May 7, 2022 · 10 comments
Labels
git installer Related to installer script status: help wanted Blocked by lack of help windows Issues related to running on Windows

Comments

@TheCodeHeist
Copy link

I don't know why this is happening, but for some reason, I can't install omf on Windows (Git Bash)! I installed fishshell easily but got stuck in this problem. I don't really know what information to provide (you can ask for it explicitly), but the information I can provide is the last terminal output:

TheCodeHeist@TheCodeHeistPC ~> curl -L https://get.oh-my.fish | fish
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   178  100   178    0     0    199      0 --:--:-- --:--:-- --:--:--   199
100 19035  100 19035    0     0  13966      0  0:00:01  0:00:01 --:--:-- 13966
Checking for a sane environment...
Install aborted: /mingw64/bin/git is Git for Windows which is not supported.
TheCodeHeist@TheCodeHeistPC ~>
@scorphus
Copy link
Member

The message says it all. Git for Windows is not supported. It has some issues that prevent a correct installation of OMF.

Maybe that has changed? Maybe those issues are solved? Do you feel like changing bin/install and seeing if it works?

You could comment the following lines:

oh-my-fish/bin/install

Lines 478 to 481 in d428b72

debug "Verifying Git implementation is not buggy Git for Windows"
if cmd git --version | cmd grep -i -q windows
abort (which git)" is Git for Windows which is not supported."
end

Proceed at your own risk:

curl https://raw.githubusercontent.com/oh-my-fish/oh-my-fish/master/bin/install > install
# comment those lines
fish install

@TheCodeHeist
Copy link
Author

I was looking for the code that sets the terminator... Thanks for showing me! But hold on...what do you mean by at your own risk? Will that destroy my PC? It wouldn't right? 🤣

@TheCodeHeist
Copy link
Author

Hell yah! Another Problem.....

TheCodeHeist@TheCodeHeistPC ~> fish install
Checking for a sane environment...
Install aborted: Please disable core.autocrlf in your Git configuration.
TheCodeHeist@TheCodeHeistPC ~>

@scorphus
Copy link
Member

I doubt there would be any harsh consequences, but one can never know. I used to have a Windows VM running somewhere in the cloud but that's not the case anymore.

So, I'm guessing you're about to comment the next few lines after those linked above and try again?

@voidptr
Copy link

voidptr commented Aug 14, 2022

FWIW, I just tried it (latest Git for Windows, disabling the check, and disabling autocrlf git config --global core.autocrlf false), and omf installed like a charm. So, maybe the check can be made a warning instead, or perhaps configurable?

@scorphus scorphus added status: help wanted Blocked by lack of help installer Related to installer script git windows Issues related to running on Windows labels Aug 14, 2022
@furopi
Copy link

furopi commented Nov 21, 2022

Thanks for the hint!!! I had to comment out "assert_cmds" in the function "sane_environment_check" on Alma Linux 9 WSL2. Now it's working fine! ❤️😊

@scorphus
Copy link
Member

Glad it works, @furopi! Would you please share which required commands were missing? Thanks!

@furopi
Copy link

furopi commented Dec 13, 2022

Glad it works, @furopi! Would you please share which required commands were missing? Thanks!

I had to comment out "assert_cmds" in the function "sane_environment_check" in the install.fish script. Then it worked 🤷‍♂️

@scorphus
Copy link
Member

Nice!

It probably complained of missing commands. I guess you don't recall which ones. Would you be willing to run that function alone and see which commands are missing? Thanks a lot!

@furopi
Copy link

furopi commented Dec 13, 2022

Nice!

It probably complained of missing commands. I guess you don't recall which ones. Would you be willing to run that function alone and see which commands are missing? Thanks a lot!

Sorry, I already deleted the Alma WSL distro, so I can't trace back the problem here... 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git installer Related to installer script status: help wanted Blocked by lack of help windows Issues related to running on Windows
Projects
None yet
Development

No branches or pull requests

4 participants