theme is installed as a plugin

[queenkjuul]

I am trying to make updates to my fish theme.

The theme is customizable, and as such I have included a config script (functions/pride.fish) which lets you change theme parameters from the command line without editing files.

The packaging as-is in the master branch works. However, I am trying to update it, and it seems that I should be putting everything in hooks/ and functions/ subdirectories. When I do this, though, omf treats it as a plugin, not a theme, so I cannot set the theme. It also seems to install my local functions directory as ~/.config/fish/functions/functions where the extra subdirectory should not be created, as far as I know.

I am not understanding what I'm doing wrong. Other themes updated in the past year seem to put everything in functions/ including themes which require helper functions.

when I run omf install /local/path/to/local/repo is it installing the files as they exist right there? it sometimes seems like it is only installing the master branch not my dev branch when it's checked out

I also notice that my theme is installed under the name pride-cat when the repo name is omf-pride-cat and I do not see anywhere where I am defining the name as pride-cat nor where I'm defining it as a theme as opposed to a plugin...

I haven't touched this in a couple years but I'm not seeing anything in the documentation to explain how omf treats plugins vs themes or how I can make a package behave more like both (a theme with extra files, basically)

You can see what I'm trying to do in the dev branch of my repo. I dont think anyone is using my theme lol but I've reset master to a working state just in case

Environment report

Oh My Fish version:   7
OS type:              Linux
Fish version:         fish, version 3.1.0
Git version:          git version 2.25.1
Git core.autocrlf:    no
Checking for a sane environment...
Your shell is ready to swim.

[scorphus]

You could try installing the theme after switching to dev update channel. Check https://github.com/oh-my-fish/oh-my-fish/#omf-channel

omf channel dev
omf update

Then install the theme. You'll probably want to set dev as the default branch on the theme repository while you test — or you can clone it and install from there omf install /path/to/local/clone. Once installed, the theme can be activated.