Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr approval process or custom package repo URLs? #890

Open
rohan-buechner opened this issue Mar 1, 2022 · 1 comment
Open

Pr approval process or custom package repo URLs? #890

rohan-buechner opened this issue Mar 1, 2022 · 1 comment

Comments

@rohan-buechner
Copy link

I use this plugin a lot.

oh-my-fish/plugin-aws

But since joining a new employer where we actively use SSO, the plugin does not pick up all profiles... I have manually updated my local plugin code to also search for SSO profiles... then wanted to make a pr for it.. I saw that there was already an open PR that is a million years old. I tested the PR's code as well, and it works fine...

oh-my-fish/plugin-aws#1

I assume the people working on everything could be swamped / that items just get missed..

Questions:

  • How could we get the above PR merged?
  • Alternatively... how can I add a custom source for my own plugin to be installable?

Sidenote, thank you for an amazing toolset (omf), I have been an avid user for a super long time 🥇

@scorphus
Copy link
Member

scorphus commented Mar 1, 2022

Thanks for bringing that to my attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants