Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Discrepancy between bestmove and nextmove during data generation. (not a bug) #3762

Open
Sopel97 opened this issue Oct 24, 2021 · 2 comments
Labels
discussion needs-analysis Needs further analysis

Comments

@Sopel97
Copy link
Member

Sopel97 commented Oct 24, 2021

The move saved during data generation is the first move from PV, but the chosen move is sometimes random (how random depends on the settings). This can harm the compression of the generated data. It's not clear whether this should be touched though, as the impact might be minor. There are 2 things that should be investigated before:

  • how much is the compression impacted for various (popular) settings, especially multipv
  • how much is the training impacted, as we determine positions 'quietness' based on the stored bestmove
@vondele
Copy link
Member

vondele commented Feb 20, 2022

With the new arch, probably tools needs an update, and maybe even for the binpack 2.0 format ? Maybe you can post the link here to the design document, if it is still active?

@Sopel97
Copy link
Member Author

Sopel97 commented Feb 20, 2022

The spec draft for "binpack 2.0" can be found here: https://docs.google.com/document/d/14KuSaQbL_9Ym5IVzIDHBwGWSrGvaajc-eki8ZJ7h1Qs/edit#heading=h.wz1dp9fb5q66

It is active but no ETA. It's fairly complex to incorporate this into the current codebase in a nice way, given how many additional options there will be. We might end up having to pretty much duplicate the generation/transform code to get the most out of it. I haven't yet started implementing it.

@Disservin Disservin added needs-analysis Needs further analysis discussion labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needs-analysis Needs further analysis
Projects
None yet
Development

No branches or pull requests

4 participants
@vondele @Sopel97 @Disservin and others