Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare_transaction doesn't handle fee parameter equal to 0 correctly #90

Open
ManFromSiberia opened this issue Dec 6, 2019 · 0 comments · May be fixed by #91
Open

prepare_transaction doesn't handle fee parameter equal to 0 correctly #90

ManFromSiberia opened this issue Dec 6, 2019 · 0 comments · May be fixed by #91

Comments

@ManFromSiberia
Copy link

When the fee parameter is set to zero in the function prepare_transaction, it processes it like None, so the bit tries to predict fee by itself, but the expected behavior is that the fee of prepared transaction will be 0.

Reason:
I need this function to calculate inputs and outputs, and I calculate the fee myself, so there are situations when there are 100,000 satoshi on the address and I want to create a transaction with this amount an error occurs that there is not enough money on the address.
ManFromSiberia added a commit to ManFromSiberia/bit that referenced this issue Dec 6, 2019
@ManFromSiberia
add correct handling for param fee in prepare_transaction when fee is 0
d2ba17c 
+sanity check for fee type, should fix ofek#90
@ManFromSiberia ManFromSiberia linked a pull request Dec 6, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add correct handling for param fee in prepare_transaction when fee is 0 ManFromSiberia/bit
1 participant
@ManFromSiberia