Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy PatternFormatter attributes #429

Open
llchan opened this issue May 8, 2024 · 1 comment
Open

Legacy PatternFormatter attributes #429

llchan opened this issue May 8, 2024 · 1 comment

Comments

@llchan
Copy link

llchan commented May 8, 2024

I see that the PatternFormatter attributes were changed in a backwards-incompatible way, and furthermore it is not evident until runtime. It would be better to keep the legacy attributes around as aliases for now, given that we did not do a major version bump.

I would suggest something like a QUILL_DISABLE_LEGACY_PATTERN_FORMATTER_ATTRIBUTES that allows users to test against the new set of attributes in an opt-in way, and when 4.0.0 lands they can be fully removed.

@odygrd
Copy link
Owner

odygrd commented May 16, 2024

I used to only bump the major version for bigger changes. In the past, numerous minor version increments broke backward compatibility without complaints.

Regarding the consideration of adding a preprocessor flag for this purpose, I don't believe it's worth the complexity and the effort. However, pull requests are welcome.

Moving forward any future incompatible API changes will result in a major version update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants