Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Time Checking of Log Messages not supported? #423

Closed
DanielekW opened this issue Apr 17, 2024 · 1 comment
Closed

Compile Time Checking of Log Messages not supported? #423

DanielekW opened this issue Apr 17, 2024 · 1 comment
Labels
question Further information is requested

Comments

@DanielekW
Copy link

DanielekW commented Apr 17, 2024

I founded this this old issue which explains that compile time checking was supported for macros:
#13

When I want to do simple test where there is an extra "{}" in formatted string:
LOG_INFO(logger, "Hello {} {}", "world" );
auto test = fmtquill::format("Hello {} {}", "world");
compile error is raised only for fmtquill::format. Does this mean that for LOG_* macros there is no compile time check?

@odygrd
Copy link
Owner

odygrd commented May 16, 2024

They were removed in v3.8.0 https://github.com/odygrd/quill/blob/master/CHANGELOG.md#v380
The reason is that they were generating extra template instantiations for each log message and also that the exception is being caught by the backend worker thread. Therefore your program won't crash and you will also see a runtime error message for an invalid format

@odygrd odygrd added the question Further information is requested label May 16, 2024
@odygrd odygrd closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants