Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__rdtscp vs __rdtsc in logger_benchmarks #420

Closed
DanielekW opened this issue Apr 15, 2024 · 1 comment
Closed

__rdtscp vs __rdtsc in logger_benchmarks #420

DanielekW opened this issue Apr 15, 2024 · 1 comment
Labels
question Further information is requested

Comments

@DanielekW
Copy link

I have a question to logger_benchmarks. In ns_per_rdtsc_tick() to convert rdtsc to wall time __rdtsc() is used while next in benchmark tests __rdtscp(&aux) is used. Why in ns_per_rdtsc_tick() you do not use __rdtscp?

@odygrd
Copy link
Owner

odygrd commented May 16, 2024

__rdtsc() should have lower overhead.
__rdtscp() has an additional serialising barrier, I believe I used it in benchmarks for more accurate results.

@odygrd odygrd added the question Further information is requested label May 16, 2024
@odygrd odygrd closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants