Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector geometries #1023

Open
kohr-h opened this issue Jun 8, 2017 · 3 comments · May be fixed by #1418
Open

Vector geometries #1023

kohr-h opened this issue Jun 8, 2017 · 3 comments · May be fixed by #1418
Labels
area: tomo type: new feature

Comments

@kohr-h
Copy link
Member

kohr-h commented Jun 8, 2017

We should have geometries that simply wrap the ASTRA vec geometries, for full flexibility regarding positions of everything. If we want to cram this into the framework of curves and all that, we can simply say that source and detector move along piecewise linear paths.
What this will need in any case is a variant of the ray transform whose range doesn't perform any weighting in the motion parameters.

I guess this is related to #152, definitely to #285.
@kohr-h kohr-h mentioned this issue Jun 8, 2017
Open
@adler-j
Copy link
Member

adler-j commented Jun 8, 2017

Also see #456 and #457.

For the motion parameters I agree.

kohr-h pushed a commit to kohr-h/odl that referenced this issue Jun 9, 2017
ENH: add vector geometries, closes odlgroup#1023
c693443
@kohr-h
Copy link
Member Author

kohr-h commented Jun 9, 2017 •
edited

I added vector geometries as a PR into the #968 branch. Works well and makes #456 and #457 quite simple to address.

kohr-h pushed a commit to kohr-h/odl that referenced this issue Jun 10, 2017
ENH: add vector geometries, closes odlgroup#1023
74e0d90
kohr-h pushed a commit to kohr-h/odl that referenced this issue Jun 27, 2017
ENH: add vector geometries, closes odlgroup#1023
910d911
kohr-h pushed a commit to kohr-h/odl that referenced this issue Sep 5, 2017
ENH: add vector geometries, closes odlgroup#1023
64b9008
kohr-h pushed a commit to kohr-h/odl that referenced this issue Sep 27, 2017
ENH: add vector geometries, closes odlgroup#1023
3e4b5a6
kohr-h pushed a commit to kohr-h/odl that referenced this issue Aug 19, 2018
@kohr-h
ENH: add vector geometries, closes odlgroup#1023
9bee03d
@kohr-h kohr-h linked a pull request Aug 22, 2018 that will close this issue
Open
2 tasks
kohr-h pushed a commit to kohr-h/odl that referenced this issue Sep 10, 2018
@kohr-h
ENH: add vector geometries, closes odlgroup#1023
87af08e
kohr-h pushed a commit to kohr-h/odl that referenced this issue Mar 13, 2019
@kohr-h
ENH: add vector geometries, closes odlgroup#1023
9d0fe03
kohr-h pushed a commit to kohr-h/odl that referenced this issue Mar 19, 2019
@kohr-h
ENH: add vector geometries, closes odlgroup#1023
0845285
kohr-h pushed a commit to kohr-h/odl that referenced this issue Mar 20, 2019
@kohr-h
ENH: add vector geometries, closes odlgroup#1023
616f7ff
kohr-h pushed a commit to kohr-h/odl that referenced this issue May 3, 2019
@kohr-h
ENH: add vector geometries, closes odlgroup#1023
c0b828c
kohr-h pushed a commit to kohr-h/odl that referenced this issue Jul 16, 2019
@kohr-h
ENH: add vector geometries, closes odlgroup#1023
6fa45d5
kohr-h pushed a commit to kohr-h/odl that referenced this issue Nov 5, 2019
@kohr-h
ENH: add vector geometries, closes odlgroup#1023
fde87ca
kohr-h pushed a commit to kohr-h/odl that referenced this issue Nov 5, 2019
@kohr-h
ENH: add vector geometries, closes odlgroup#1023
c426744
kohr-h pushed a commit to kohr-h/odl that referenced this issue Sep 6, 2020
@kohr-h
ENH: add vector geometries, closes odlgroup#1023
d24bad2
@C-Kingsley
Copy link

We should have geometries that simply wrap the ASTRA vec geometries, for full flexibility regarding positions of everything. If we want to cram this into the framework of curves and all that, we can simply say that source and detector move along piecewise linear paths. What this will need in any case is a variant of the ray transform whose range doesn't perform any weighting in the motion parameters.

I guess this is related to #152, definitely to #285.

Hi, I'm just working on geometry with piecewise linear sources and detectors. Could you please give some guidance for the implementation of 'geometry' and 'ray transform' using ODL? Thanks!! @kohr-h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tomo type: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Add vector geometries kohr-h/odl
3 participants
@adler-j @kohr-h @C-Kingsley