Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification phase to CLI before installing #950

Open
edeNFed opened this issue Feb 5, 2024 · 6 comments · May be fixed by #986
Open

Add verification phase to CLI before installing #950

edeNFed opened this issue Feb 5, 2024 · 6 comments · May be fixed by #986
Assignees
Labels
go Pull requests that update Go code help wanted Extra attention is needed stale

Comments

@edeNFed
Copy link
Contributor

edeNFed commented Feb 5, 2024

We would like to add a verification phase before applying resources in the odigos install command.
This verification mechanism should be easily extensible as we will add more verifications.
Each verification should also recommend to the user how to mitigate in case the verification is failed.

Some of the proposed verifications:

  • Check if PodSecurityPolicy is enabled. If enabled the user should use --psp flag when installing
  • Check if OPA Gatekeeper is installed, if installed, the user should whiltelist the odigos-system namespace by following this guide.
  • Check kernel versions of running nodes
@edeNFed edeNFed added help wanted Extra attention is needed go Pull requests that update Go code labels Feb 5, 2024
@clavinjune
Copy link
Contributor

could you please assign me on this @edeNFed? but I need more elaboration on the technicality

@clavinjune clavinjune linked a pull request Feb 16, 2024 that will close this issue
@clavinjune
Copy link
Contributor

could you please help to review the proposal on how we're gonna add verification phase #986 @edeNFed? thank you 🙇

@clavinjune
Copy link
Contributor

could you please elaborate the Check kernel versions of running nodes part @edeNFed ? thank you 🙇

@clavinjune
Copy link
Contributor

also, when executingodigos install, user have a flexibility to define the namespace, right? so we need to check user-inputted namespace instead of odigos-system for allow-listed?

@edeNFed
Copy link
Contributor Author

edeNFed commented Feb 18, 2024

could you please elaborate the Check kernel versions of running nodes part @edeNFed ? thank you 🙇

We should check that at least one Kubernetes node has kernelVersion above 4.14. You can get the kernel version from the nodeInfo field of the node:

  nodeInfo:
    architecture: arm64
    bootID: 98511e31-ee92-4cdf-bfc7-0791f0e58dff
    containerRuntimeVersion: containerd://1.6.9
    kernelVersion: 6.5.11-linuxkit

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code help wanted Extra attention is needed stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants