Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use DockerImage from ENV variable #749

Open
ashish0x02 opened this issue Nov 6, 2023 · 6 comments
Open

use DockerImage from ENV variable #749

ashish0x02 opened this issue Nov 6, 2023 · 6 comments
Labels

Comments

@ashish0x02
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

please update hardcoded image to use configurable image tags.
https://github.com/keyval-dev/odigos/blob/de3daf79e33f1f5ff8e5f97c3134aaeed01d6811/autoscaler/controllers/gateway/deployment.go#L24

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
it will become a blocker to many orgs whose workload is 500+ nodes and which are using private ECR repo(it will throw Docker rate limit error)

Additional context
Add any other context or screenshots about the feature request here.

@edeNFed
Copy link
Contributor

edeNFed commented Nov 6, 2023

Hi @ashish0x02
We currently have a flag named --image-prefix which you can use during installation to use private image repos instead of docker hub.

@ashish0x02
Copy link
Author

is it kind of env variable which I need to pass as k8s ENV during run time?

@blumamir
Copy link
Collaborator

is it kind of env variable which I need to pass as k8s ENV during run time?

You can set it when you run odigos install.
Reference: https://docs.odigos.io/cli/odigos_install#options

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jan 22, 2024
@blumamir
Copy link
Collaborator

Hi @ashish0x02

Can you please share if this is resolved or you still need help with this issue?

Please note that we recently upgraded the collector image to use v0.91.0.
If you need to use a different docker registry than dockerhub, you can use the --image-prefix as described above.

@github-actions github-actions bot removed the stale label Mar 11, 2024
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants