Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resource detectors to nodejs instrumentation agent #582

Open
blumamir opened this issue Oct 4, 2023 · 3 comments
Open

add resource detectors to nodejs instrumentation agent #582

blumamir opened this issue Oct 4, 2023 · 3 comments
Labels

Comments

@blumamir
Copy link
Collaborator

blumamir commented Oct 4, 2023

Currently odigos nodejs instrumentation agent includes a few resource detectors.

    "@opentelemetry/resource-detector-alibaba-cloud": "0.28.1",
    "@opentelemetry/resource-detector-aws": "1.3.1",
    "@opentelemetry/resource-detector-container": "0.3.1",
    "@opentelemetry/resource-detector-gcp": "0.29.1",

Those resource detectors are installed as dependencies, but I think they should be used in code, by setting the resourceDetectors property in the NodeSDKConfiguration object here.

It seems that we can also add additional resource detectors that are currently not used. See the available detectors here

@blumamir blumamir added enhancement New feature or request good first issue Good for newcomers hacktoberfest nodejs labels Oct 4, 2023
@Chirag-Nanda
Copy link

can this issue be assigned to me?

@major-winter
Copy link

Hello, the issue is stale. Is the issue still relevant? If so, I would like to work on it.

@rauno56
Copy link
Collaborator

rauno56 commented Apr 2, 2024

Still relevant, @major-winter.

@odigos-io odigos-io deleted a comment from github-actions bot Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants