Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report destinations errors and status in the odigos ui #1079

Open
blumamir opened this issue Mar 18, 2024 · 3 comments
Open

Report destinations errors and status in the odigos ui #1079

blumamir opened this issue Mar 18, 2024 · 3 comments
Assignees
Labels

Comments

@blumamir
Copy link
Collaborator

Currently, users can add new destination and add configuration options for them.

If there is an issue with the configuration, for example if the endpoint is invalid, odigos auto-scaler component will log the error and will not show any indication in the UI.

This issue is to add indication for the destination. So if everything goes well, the destination should indicate it, and if there are errors, I want to have the error message so the user can fix it.

To do that, we will need:

  1. Add Status to the destination CRD here which should include Conditions similar to the ones in actions.
  2. For all destinations, return an error from the ModifyConfig function, and write the error to the destination CRD or indicate success if there is no error. This should be applied here.

After this step, the user can see any status and error in the CRD. The next step after this is done would be to report this data in the frontent code so it is accessible to odigos UI.

@ankur0904
Copy link
Contributor

@blumamir I am interested in working on this issue

@blumamir
Copy link
Collaborator Author

@blumamir I am interested in working on this issue

Thanks @ankur0904 let me know how it goes and if you have any questions or need assistance

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants