Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Move all types to Octokit namespace #2845

Open
1 task done
TanukiSharp opened this issue Jan 4, 2024 · 2 comments
Open
1 task done

[FEAT]: Move all types to Octokit namespace #2845

TanukiSharp opened this issue Jan 4, 2024 · 2 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request

Comments

@TanukiSharp
Copy link

TanukiSharp commented Jan 4, 2024 •
edited

Describe the need

Could you move all types to the Octokit namespace please ?

Today I realized (the hard way) that Artifact and ArtifactWorkflowRun types have no namespace, and it messed up my work since we also have a type named Artifact. I recently updated from 7.1 to 9.0 and apparently that's the reason, the type Artifact was added in commit 958bc5f and broke our code.

While you are at it, please make sure there are no other types without namespace.

Thanks.

SDK Version

Octokit.net v9.0.0

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@TanukiSharp TanukiSharp added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Jan 4, 2024
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone Type: Breaking change Used to note any change that requires a major version bump and removed Status: Triage This is being looked at and prioritized labels Jan 4, 2024
@anjolaoluwaakindipe
Copy link

Is it cool if I could tackle this issue

@wesdevpro
Copy link
Contributor

Is it cool if I could tackle this issue

Absolutely! It's up for grabs. Take a whack at it!

@anjolaoluwaakindipe anjolaoluwaakindipe mentioned this issue Jan 28, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request
Projects
🧰 Octokit Active
Status: 🔥 Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nickfloyd @TanukiSharp @wesdevpro @anjolaoluwaakindipe